Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user in automation context #14825

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Oct 18, 2024

Description

This passes through the user from row based triggers as well as the app trigger into the automation context. This will allow the binding of user values within automations. Frontend will need to go in on the v3 branch.

Addresses

https://linear.app/budibase/issue/BUDI-8721/automations-current-user-binding-not-available

@PClmnt PClmnt requested a review from a team as a code owner October 18, 2024 14:10
@PClmnt PClmnt requested review from mike12345567 and removed request for a team October 18, 2024 14:10
Copy link

qa-wolf bot commented Oct 18, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Oct 18, 2024
packages/server/src/automations/triggers.ts Outdated Show resolved Hide resolved
packages/server/src/automations/triggers.ts Outdated Show resolved Hide resolved
packages/server/src/api/controllers/automation.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to get this in, left a few comments about typing improvements/clarifications, but giving a pre-approval as none of these changes are blocking.

@PClmnt PClmnt merged commit 6f3ee89 into master Oct 22, 2024
12 checks passed
@PClmnt PClmnt deleted the feat/support-user-in-automation-context branch October 22, 2024 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants