Fix view v1 on tables #15427
Merged
Fix view v1 on tables #15427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
commented
Jan 23, 2025
| @@ -1,5 +1,3 @@ | |||
| // TODO: datasource and defitions are unions of the different implementations. At this point, the datasource does not know what type is being used, and the assignations will cause TS exceptions. Casting it "as any" for now. This should be fixed improving the type usages. | |||
There was a problem hiding this comment.
All these TODOS are not needed anymore
adrinr
commented
Jan 23, 2025
| @@ -21,7 +21,7 @@ export default class ViewFetch extends BaseDataFetch<ViewV1Datasource, Table> { | |||
|
|
|||
| getSchema(definition: Table) { | |||
| const { datasource } = this.options | |||
| return definition?.views?.[datasource.name]?.schema | |||
| return definition?.views?.[datasource?.name]?.schema | |||
There was a problem hiding this comment.
This was causing errors when trying to fetch the data, as at some reactivity updates the datasource was undefined
aptkingston
approved these changes
Jan 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing broken tables for viewV1, probably broken during the typification of the data fetchers: https://github.com/Budibase/budibase/pull/15295/files
This PR fixes it, while ensuring that not extra calls are made during some initialisation of forms or similar (we had that case in the past with some changes)
Launchcontrol
Fixing tables for viewV1