Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate screen field datasource settings #15440

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Jan 27, 2025

Description

Following #15439 and #15433, validate data providers settings of type fields

Screenshots

Screen.Recording.2025-01-27.at.11.50.24.mov

Launchcontrol

Validation fields in datasource settings in components.

Copy link

linear bot commented Jan 27, 2025

Copy link

qa-wolf bot commented Jan 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Jan 27, 2025
@adrinr adrinr changed the title Validate screen relationship datasource settings Validate screen field datasource settings Jan 27, 2025
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from BUDI-8986/validate-screen-datasources to master January 27, 2025 12:03
@adrinr adrinr merged commit 7c17d01 into master Jan 27, 2025
19 checks passed
@adrinr adrinr deleted the BUDI-8986/validate-screen-datasources-fields branch January 27, 2025 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants