Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a typing pass on automation.spec.ts #15453

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Jan 28, 2025

Description

This updates automation.spec.ts and a few surrounding files to make use of config.api.automation instead of the older config.createAutomation and friends.

@samwho samwho requested a review from adrinr January 28, 2025 17:43
@samwho samwho requested a review from a team as a code owner January 28, 2025 17:43
Copy link

qa-wolf bot commented Jan 28, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/l labels Jan 28, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just re-ordered the lines in this file to be alphabetical so it's a bit easier to scan through them.

Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwho samwho enabled auto-merge January 29, 2025 11:07
@samwho samwho merged commit c85340e into master Jan 29, 2025
20 checks passed
@samwho samwho deleted the budi-9015-looped-automation-steps-showing-up-in-test-results-after-a branch January 29, 2025 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants