Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out new code editor field and drawer bindable slot into single component #15545

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

aptkingston
Copy link
Member

Description

Ensures we keep the drawer and new code editor field in sync.

Copy link

qa-wolf bot commented Feb 13, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Besides the lint issues, this looks great. I ran through it locally here and it successfully alleviates the timing issue on blur. I'll be sure to mirror this approach in the automation sidebar updates too 🚀 Cheers!

@aptkingston aptkingston marked this pull request as ready for review February 13, 2025 13:14
@aptkingston aptkingston merged commit ca0630c into execute-script-v2-frontend Feb 13, 2025
19 checks passed
@aptkingston aptkingston deleted the execute-script-tweaks branch February 13, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants