Automation Orchestrator refactor. #15546
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
changed the title
adrinr
reviewed
Feb 14, 2025
| @@ -1134,7 +1138,7 @@ const automationActions = (store: AutomationStore) => ({ | |||
| * @returns | |||
| */ | |||
| shiftBranch: (pathTo: Array<any>, block: AutomationStep, direction = -1) => { | |||
There was a problem hiding this comment.
Should the block input not be BranchStep instead?
| @@ -13,19 +13,17 @@ export interface TriggerOutput { | |||
| timestamp?: number | |||
| } | |||
|
|
|||
| export interface AutomationContext extends AutomationResults { | |||
| export interface AutomationContext { | |||
| trigger: any | |||
There was a problem hiding this comment.
Should this not be an AutomationTrigger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation for this is a bug in the automation test output when combining a filter step with loop steps: https://linear.app/budibase/issue/BUDI-9015/looped-automation-steps-showing-up-in-test-results-after-a-failed.
In reading the code to try and fix this, I decided to take the plunge and change the way the Orchestrator works in order to make this bug fix easier.
My recommendation for reviewing this is to pull the branch into your local environment and start reading from
packages/server/src/threads/automation.ts. That's where theOrchestratorclass, the thing that runs automations, lives and where most of the changes are concentrated.Addresses