Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for with_name with deferred_init and disabled hoisting … #67

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

AjayBrahmakshatriya
Copy link
Collaborator

…variables that escape static scope

This pull request makes 2 changes -

  1. Adds support for using builder::with_name with deferred_init. This is a simple change that just adds an overload.
  2. Reverts the changes made in Fixed bug with dynamic variables escaping static scopes getting diffe… #60 . The rationale is as follows - The previous changes causes variables that escape scope to be merged and hoisted up. But this causes issues when dyn_vars or structs containing dyn_vars are heap allocated in a static loop.
    We are defaulting to no hoisting the variables and we can add a metadata if the hoisting behavior is needed. In the future the proper fix would be to selectively merge paths only when the live dynamic variables on both the side are the same.

TODO: Implement the proper fix.

@AjayBrahmakshatriya AjayBrahmakshatriya merged commit 51e6512 into BuildIt-lang:master Feb 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant