Upgrade to BuildingSync Version 2.5 #21
Conversation
Add all new elements
|
This has to wait until we release BuildingSync v2.5. |
bsyncpy/bsync.py
Outdated
| "Associated Air Balance Council (AABC) Certified Member Agency", | ||
| "Associated Air Balance Council (AABC) Test and Balance Technician", | ||
| "Association of Energy Engineers Certified Building Commissioning Firm Program (CBCF)", |
There was a problem hiding this comment.
| "Association of Energy Engineers Certified Building Commissioning Firm Program (CBCF)", | |
| "Association of Energy Engineers Certified Building Commissioning Firm (CBCF)", |
There was a problem hiding this comment.
@ThibaultMarzullo, Aside from the redundant whitespace after "Firm", I agree with the suggested change.
There was a problem hiding this comment.
| "Association of Energy Engineers Certified Building Commissioning Firm Program (CBCF)", | |
| "Association of Energy Engineers Certified Building Commissioning Firm (CBCF)", |
Thank you Mark
bsyncpy/bsync.py
Outdated
| "International Union of Operating Engineers Certified Energy Specialist", | ||
| "MEP Professional Engineer", |
There was a problem hiding this comment.
| "MEP Professional Engineer", | |
| "Mechanical, Electrical and Plumbing (MEP) Professional Engineer (PE)", |
There was a problem hiding this comment.
@ThibaultMarzullo, I agree with the suggested change.
bsyncpy/bsync.py
Outdated
| "International Union of Operating Engineers Certified Energy Specialist", | ||
| "MEP Professional Engineer", | ||
| "NYSERDA FlexTech Consultant", |
There was a problem hiding this comment.
| "NYSERDA FlexTech Consultant", | |
| "New York State Energy Research and Development Authority (NYSERDA) FlexTech Consultant", |
There was a problem hiding this comment.
@ThibaultMarzullo, I agree with the suggested change.
| @@ -281,7 +281,7 @@ def do_simpleType(element) -> BSElement: | |||
| if union_type.startswith("auc:"): | |||
| bs_element.element_union.append(union_type[4:]) | |||
| else: | |||
| raise RuntimError(f"union out of scope: {union_type}") | |||
| raise RuntimeError(f"union out of scope: {union_type}") | |||
|
Some of the suggestions above might have to be reflected in the schema. |
|
@markborkum @ThibaultMarzullo The comments related to the enumerations under |
|
looking good! a few stray "2.4" in |
|
@ThibaultMarzullo It seems there are just a few modifications on the enumerations. Do we want to include the changes in 2.5 release? We may need to confirm with @nllong if these are counted as breaking changes or not. |
|
Thank you @haneslinger and @markborkum for your review! @JieXiong9119 feel free to include in 2.5 if we are still on time. Thank you for updating this! |
No description provided.