-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to Node v20 #114
upgrade to Node v20 #114
Conversation
I believe we just need to add https://github.com/google-github-actions/release-please-action#how-should-i-write-my-commits so I think it would be |
@marcinpece-apptension can you provide a second set of testing eyes on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on wrong node version https://share.zight.com/P8uKlWKn ✅
on correct node version https://share.zight.com/GGub0L9L ✅
tests passed https://share.zight.com/8LuWZdKk ✅
LGTM 🎉
@courcelan if you fix commit message, I can re-check and merge |
bcc0d20
to
54bcb62
Compare
@ViolanteCodes good for your review / release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Node v20 has moved into LTS and we are matching our library to their LTS.
Please check that it operates for you.
@ViolanteCodes - we'll need a refresher on how to move this to version 3.0.0 (its currently at 2.3.1) and we'll need to tag the current master for NPM use I think