Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Node v20 #114

Merged
merged 1 commit into from
Dec 19, 2024
Merged

upgrade to Node v20 #114

merged 1 commit into from
Dec 19, 2024

Conversation

courcelan
Copy link
Contributor

Node v20 has moved into LTS and we are matching our library to their LTS.

Please check that it operates for you.

@ViolanteCodes - we'll need a refresher on how to move this to version 3.0.0 (its currently at 2.3.1) and we'll need to tag the current master for NPM use I think

@courcelan
Copy link
Contributor Author

@ViolanteCodes
Copy link
Contributor

@courcelan

I believe we just need to add ! to commit message:

https://github.com/google-github-actions/release-please-action#how-should-i-write-my-commits

so I think it would be feat!: upgrade to node 20

@ViolanteCodes
Copy link
Contributor

@marcinpece-apptension can you provide a second set of testing eyes on this?

Copy link
Contributor

@marcinpece-apptension marcinpece-apptension left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on wrong node version https://share.zight.com/P8uKlWKn
on correct node version https://share.zight.com/GGub0L9L
tests passed https://share.zight.com/8LuWZdKk

LGTM 🎉

@ViolanteCodes
Copy link
Contributor

I believe we just need to add ! to commit message:

https://github.com/google-github-actions/release-please-action#how-should-i-write-my-commits

so I think it would be feat!: upgrade to node 20

@courcelan if you fix commit message, I can re-check and merge

@courcelan courcelan force-pushed the 2024-12-node-v20-upgrade branch from bcc0d20 to 54bcb62 Compare December 19, 2024 07:24
@courcelan
Copy link
Contributor Author

@ViolanteCodes good for your review / release

Copy link
Contributor

@ViolanteCodes ViolanteCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViolanteCodes ViolanteCodes merged commit 8aa102a into master Dec 19, 2024
@ViolanteCodes ViolanteCodes deleted the 2024-12-node-v20-upgrade branch December 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants