-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore(BUX-298): refactor sync method and use go-b t structures in BEEF implementation #438
Conversation
beef_tx_sorting_test.go
Outdated
|
||
return result | ||
} | ||
//func Test_kahnTopologicalSortTransaction(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we do not have access to private fields from bt, so it's not trivali to create reliable tests for this here in bux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we should remove this test entirely and have a good tests on an upper level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to write tests for these
f467dfe
to
321db32
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 52.65% 52.46% -0.19%
==========================================
Files 96 96
Lines 10703 10732 +29
==========================================
- Hits 5636 5631 -5
- Misses 4626 4660 +34
Partials 441 441
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Checklist