Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

chore(BUX-298): refactor sync method and use go-b t structures in BEEF implementation #438

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner October 20, 2023 07:21
@pawellewandowski98 pawellewandowski98 self-assigned this Oct 20, 2023
@mergify mergify bot added the update General updates label Oct 20, 2023

return result
}
//func Test_kahnTopologicalSortTransaction(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is commented out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we do not have access to private fields from bt, so it's not trivali to create reliable tests for this here in bux.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we should remove this test entirely and have a good tests on an upper level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to write tests for these

beef_tx.go Outdated Show resolved Hide resolved
beef_tx_bytes.go Outdated Show resolved Hide resolved
beef_tx_sorting.go Outdated Show resolved Hide resolved
beef_tx_sorting.go Outdated Show resolved Hide resolved
@arkadiuszos4chain arkadiuszos4chain force-pushed the chore-refactor-sync-method branch from f467dfe to 321db32 Compare October 20, 2023 11:49
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #438 (5788912) into master (27d80ad) will decrease coverage by 0.19%.
Report is 3 commits behind head on master.
The diff coverage is 48.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   52.65%   52.46%   -0.19%     
==========================================
  Files          96       96              
  Lines       10703    10732      +29     
==========================================
- Hits         5636     5631       -5     
- Misses       4626     4660      +34     
  Partials      441      441              
Flag Coverage Ξ”
unittests 52.46% <48.07%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
beef_tx_sorting.go 100.00% <100.00%> (ΓΈ)
beef_tx_bytes.go 78.33% <83.33%> (+3.73%) ⬆️
beef_tx.go 54.66% <46.15%> (-10.13%) ⬇️
model_sync_transactions.go 20.65% <0.00%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 27d80ad...5788912. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain merged commit c19ef9d into master Oct 25, 2023
10 of 11 checks passed
@arkadiuszos4chain arkadiuszos4chain deleted the chore-refactor-sync-method branch October 25, 2023 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants