Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Feat(BUX-305): BUMP. Replace slice of maps with slice of slices #445

Closed
wants to merge 1 commit into from

Conversation

witalij-4chain
Copy link

@witalij-4chain witalij-4chain commented Oct 26, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Example of calculated BUMP:

{
  "blockHeight": "815515",
  "path": [
    [
      {
        "offset": "616704",
        "hash": "b5c48b4b531ba3d396f4c1898e52f0ae58a687da4c23f75f1ac2a570dce4d955"
      },
      {
        "offset": "616705",
        "hash": "0834dfa2e2cca8386a45a2c70a96e39964eab9b1d2e5f1c70907ff64c19ed0b0",
        "txid": true
      }
    ],
    [
      {
        "offset": "308353",
        "hash": "d098097af5372a2aa20423a239c8c6b8956377e80d5e1fceccec5c8ee647a4aa"
      }
    ],
    [
      {
        "offset": "154177",
        "hash": "114bbbb735cdbbc7babfe5397fdc2f94da72a2ee319025bb93b4ee81629fb0c3"
      }
    ],
    [
      {
        "offset": "77089",
        "hash": "b09dda52522507978c19d9a37d7ff04f9a3ee84093e2ec2029710e404da60298"
      }
    ],
    [
      {
        "offset": "38545",
        "hash": "5774d63175631c576a3ad2c86d5b04cdb621b5fe6b10b82bd0647c0899d39c92"
      }
    ],
    [
      {
        "offset": "19273",
        "hash": "4083a0d8dc07be429a399134170d8ca622aa0ffe6e2d0ad480af6de3b5c234e8"
      }
    ],
    [
      {
        "offset": "9637",
        "hash": "c2673edbb2e8df441d444032fda07b849c5f701707511c33e7eed7811fd295fc"
      }
    ],
    [
      {
        "offset": "4819",
        "hash": "3bf6e3573eea5a04b61f7efb7432c3485257e12ac7f45ff3f4c3f90e9526c6d8"
      }
    ],
    [
      {
        "offset": "2408",
        "hash": "db16979f5a9b9ef23c4760aa453bf66e1a70d4451930551bf7b9672e605e53f9"
      }
    ],
    [
      {
        "offset": "1205",
        "hash": "cf67ee936f0f96f629bb5ba2e3d934ace9367361b55f135fcd43d09a9d8f222f"
      }
    ],
    [
      {
        "offset": "603",
        "hash": "87f896542d89ea196b88fef9e6efe122c6bd24fea7e6de6319f152d679a711bf"
      }
    ],
    [
      {
        "offset": "300",
        "hash": "6e28252c5952f22365fdae86619289ef3a530b223dc85c9a02ac87c8bb1a2f11"
      }
    ],
    [
      {
        "offset": "151",
        "hash": "6591e497201648fd7634118d700585a45f993e7385e19aef2b5b25ed9f10902a"
      }
    ],
    [
      {
        "offset": "74",
        "hash": "f06a7d87ef76e8c9eee80d118705cd6a6f88a7d695eb3dbf1e33f5310704a2a2"
      }
    ],
    [
      {
        "offset": "36",
        "hash": "ce62ea506662d7b2ca201c8121995af51119a6e3b19807cbf8290a0637b54798"
      }
    ],
    [
      {
        "offset": "19",
        "hash": "037071ccad160d9c6340c480baa8a9a264b728015fed602a001435dfd03483b9"
      }
    ],
    [
      {
        "offset": "8",
        "hash": "28c5db73158f5a4728547ee933ee6c14b2e7d56307fdb7a0b417f6477262ab05"
      }
    ],
    [
      {
        "offset": "5",
        "hash": "e99abe2a6ae9cf8282c8b6f81924d1f53360723c9566ca1e6918b98817387656"
      }
    ],
    [
      {
        "offset": "3",
        "hash": "ad7ffd37646488bcdaab7f82d4e1a18215020b1e31da99ca54ab29cc459e6b11"
      }
    ],
    [
      {
        "offset": "0",
        "hash": "cfc43ec68a90633626337bd5588be03f24b2e1c7364e8cf48ce36b0e81f4c879"
      }
    ]
  ]
}

@witalij-4chain witalij-4chain requested a review from a team as a code owner October 26, 2023 08:23
@mergify mergify bot added the feature Any new significant addition label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #445 (51ac7b5) into master (b6d63ae) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   52.55%   52.56%           
=======================================
  Files         102      102           
  Lines       10827    10829    +2     
=======================================
+ Hits         5690     5692    +2     
  Misses       4690     4690           
  Partials      447      447           
Flag Coverage Ξ”
unittests 52.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
model_bump.go 16.66% <ΓΈ> (ΓΈ)
model_merkle_proof.go 83.56% <100.00%> (+0.46%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b6d63ae...51ac7b5. Read the comment docs.

@witalij-4chain witalij-4chain requested a review from a team October 26, 2023 13:10
@witalij-4chain
Copy link
Author

Cancelled. Will be implemented in BUX-294

Copy link
Contributor

mergify bot commented Nov 17, 2023

Welcome to our open-source project @witalij-4chain! πŸ’˜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants