Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-294): Replacing CMPSlice with BUMPPaths in DraftTransaction #448

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

kuba-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@kuba-4chain kuba-4chain requested a review from a team October 27, 2023 11:55
@kuba-4chain kuba-4chain requested a review from a team as a code owner October 27, 2023 11:55
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2023

Welcome to our open-source project @kuba-4chain! πŸ’˜

model_bump.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #448 (981edef) into master (b6d63ae) will decrease coverage by 0.88%.
Report is 3 commits behind head on master.
The diff coverage is 80.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   52.55%   51.67%   -0.88%     
==========================================
  Files         102      102              
  Lines       10827    10963     +136     
==========================================
- Hits         5690     5665      -25     
- Misses       4690     4864     +174     
+ Partials      447      434      -13     
Flag Coverage Ξ”
unittests 51.67% <80.59%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
model_compound_merkle_path.go 64.51% <ΓΈ> (-9.17%) ⬇️
model_merkle_proof.go 78.26% <100.00%> (-4.84%) ⬇️
model_draft_transactions.go 71.32% <11.11%> (-1.49%) ⬇️
model_bump.go 67.79% <80.85%> (+51.12%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b6d63ae...981edef. Read the comment docs.

@kuba-4chain kuba-4chain merged commit 52348c9 into master Oct 27, 2023
9 of 10 checks passed
@mergify mergify bot deleted the bux-294-replacing-cmp-with-bump branch October 27, 2023 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants