Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

fix(BUX-250): BUMP-related fixes found during testing #466

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

arkadiuszos4chain
Copy link
Contributor

@arkadiuszos4chain arkadiuszos4chain commented Nov 8, 2023

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@arkadiuszos4chain arkadiuszos4chain requested a review from a team as a code owner November 8, 2023 15:01
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Nov 8, 2023
@arkadiuszos4chain arkadiuszos4chain requested a review from a team November 8, 2023 15:02
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #466 (153ddd2) into feat-291-change-broadcast-rc (e618fcb) will decrease coverage by 0.74%.
Report is 1 commits behind head on feat-291-change-broadcast-rc.
The diff coverage is 70.67%.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           feat-291-change-broadcast-rc     #466      +/-   ##
================================================================
- Coverage                         53.13%   52.40%   -0.74%     
================================================================
  Files                               106      106              
  Lines                             11056    11174     +118     
================================================================
- Hits                               5875     5856      -19     
- Misses                             4713     4849     +136     
- Partials                            468      469       +1     
Flag Coverage Ξ”
unittests 52.40% <70.67%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
model_transactions.go 77.89% <100.00%> (-0.12%) ⬇️
db_model_transactions.go 58.78% <0.00%> (+0.35%) ⬆️
model_merkle_proof.go 85.18% <82.35%> (-2.49%) ⬇️
model_draft_transactions.go 72.62% <55.55%> (-0.22%) ⬇️
model_bump.go 69.43% <70.47%> (-6.63%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update e618fcb...153ddd2. Read the comment docs.

@arkadiuszos4chain
Copy link
Contributor Author

Approved by me in previous PR :D

@arkadiuszos4chain arkadiuszos4chain merged commit cf413a1 into feat-291-change-broadcast-rc Nov 8, 2023
1 check passed
@mergify mergify bot deleted the fix-250-bump-fixes branch November 8, 2023 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants