BUX-480: Record Transaction

action_transaction_test.go

@@ -187,6 +187,37 @@ func Test_RevertTransaction(t *testing.T) {
 	})
 }
 
+func Test_RecordTransaction(t *testing.T) {
+	//var secondTransaction *Transaction
+	t.Run("record transaction", func(t *testing.T) {
+		ctx, client, _ := initSimpleTestCase(t)
+		// given
+		draftTransaction := newDraftTransaction(
+			testXPub, &TransactionConfig{
+				Outputs: []*TransactionOutput{{
+					To:       "1A1PjKqjWMNBzTVdcBru27EV1PHcXWc63W",
+					Satoshis: 1000,
+				}},
+				ChangeNumberOfDestinations: 1,
+				Sync: &SyncConfig{
+					Broadcast:        true,
+					BroadcastInstant: false,
+					PaymailP2P:       false,
+					SyncOnChain:      false,
+				},
+			},
+			append(client.DefaultModelOptions(), New())...,
+		)
+
+		// when
+		_, err := client.RecordTransaction(ctx, testXPub, "test", draftTransaction.ID, client.DefaultModelOptions()...)
+
+		//then
+		require.Error(t, err)
+	})
+
+}
+
 func initRevertTransactionData(t *testing.T) (context.Context, ClientInterface, *Transaction, *bip32.ExtendedKey, func()) {
 	// this creates an xpub, destination and utxo
 	ctx, client, deferMe := initSimpleTestCase(t)

paymail_service_provider.go

@@ -157,11 +157,18 @@ func (p *PaymailDefaultServiceProvider) RecordTransaction(ctx context.Context,
 	metadata[p2pMetadataField] = p2pTx.MetaData
 	metadata[ReferenceIDField] = p2pTx.Reference
 
+	//var rts recordIncomingTxStrategy
+	//if err := rts.Validate(); err != nil {
+	//	return nil, err
+	//}
 	// Record the transaction
 	rts, err := getIncomingTxRecordStrategy(ctx, p.client, p2pTx.Hex)
 	if err != nil {
 		return nil, err
 	}
+	if err := rts.Validate(); err != nil {
+		return nil, err
+	}
 
 	rts.ForceBroadcast(true)
 

record_tx_strategy_external_incoming_tx.go

@@ -59,6 +59,10 @@ func (strategy *externalIncomingTx) Validate() error {
 		return ErrMissingFieldHex
 	}
 
+	if _, err := bt.NewTxFromString(strategy.Hex); err != nil {
+		return fmt.Errorf("invalid hex: %w", err)
+	}
+
 	return nil // is valid
 }
 

record_tx_strategy_internal_incoming_tx.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/libsv/go-bt/v2"
 	"github.com/rs/zerolog"
 )
 
@@ -52,6 +53,10 @@ func (strategy *internalIncomingTx) Validate() error {
 		return errors.New("tx cannot be nil")
 	}
 
+	if _, err := bt.NewTxFromString(strategy.Tx.Hex); err != nil {
+		return fmt.Errorf("invalid hex: %w", err)
+	}
+
 	return nil // is valid
 }
 

record_tx_strategy_outgoing_tx.go

@@ -70,6 +70,10 @@ func (strategy *outgoingTx) Validate() error {
 		return ErrMissingFieldHex
 	}
 
+	if _, err := bt.NewTxFromString(strategy.Hex); err != nil {
+		return fmt.Errorf("invalid hex: %w", err)
+	}
+
 	if strategy.RelatedDraftID == "" {
 		return errors.New("empty RelatedDraftID")
 	}