-
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc-v1.1 #558 +/- ##
===========================================
- Coverage 56.82% 53.60% -3.22%
===========================================
Files 102 110 +8
Lines 9876 10890 +1014
===========================================
+ Hits 5612 5838 +226
- Misses 3826 4583 +757
- Partials 438 469 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
action_transaction.go
Outdated
} | ||
|
||
tx.setChainInfo(txInfo) | ||
if err = tx.Save(ctx); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update SyncTransaction model otherwise, we will try to check the state of updated transaction during next scheduled trigger.
Actually I would suggest to make this function a common code used in callbacks and in scheduled synchronisation (so actually move there and unify code that is in a sync transaction after querying chain).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good point. I tried to handle that.
8669665
to
c516d93
Compare
What was done?
Pull Request Checklist