Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-368): Arc Callbacks #558

Closed
wants to merge 9 commits into from
Closed

feat(BUX-368): Arc Callbacks #558

wants to merge 9 commits into from

Conversation

wregulski
Copy link
Contributor

@wregulski wregulski commented Jan 31, 2024

What was done?

  1. Created business logic methods to handle broadcast callbacks from broadcast client.
  2. Changed syncTx task from 2minutes interval to 10minutes interval.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski added the feature Any new significant addition label Jan 31, 2024
@wregulski wregulski self-assigned this Jan 31, 2024
@wregulski wregulski requested a review from a team as a code owner January 31, 2024 09:32
@wregulski wregulski marked this pull request as draft January 31, 2024 09:32
@wregulski wregulski changed the base branch from master to rc-v1.1 January 31, 2024 09:32
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (fbc92f3) 56.82% compared to head (ae3ab24) 53.60%.
Report is 60 commits behind head on rc-v1.1.

❗ Current head ae3ab24 differs from pull request most recent head 2547350. Consider uploading reports for the commit 2547350 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           rc-v1.1     #558      +/-   ##
===========================================
- Coverage    56.82%   53.60%   -3.22%     
===========================================
  Files          102      110       +8     
  Lines         9876    10890    +1014     
===========================================
+ Hits          5612     5838     +226     
- Misses        3826     4583     +757     
- Partials       438      469      +31     
Flag Coverage Δ
unittests 53.60% <50.49%> (-3.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentication.go 80.52% <100.00%> (+0.02%) ⬆️
beef_bump.go 78.33% <100.00%> (ø)
beef_tx_sorting.go 100.00% <100.00%> (ø)
chainstate/broadcast_providers.go 63.93% <100.00%> (+3.22%) ⬆️
chainstate/merkle_root.go 83.33% <100.00%> (+83.33%) ⬆️
chainstate/minercraft_init.go 82.35% <100.00%> (+18.48%) ⬆️
chainstate/mock_minercraft.go 27.95% <100.00%> (+11.54%) ⬆️
client.go 60.50% <ø> (-4.70%) ⬇️
cron_job_declarations.go 87.50% <100.00%> (+2.50%) ⬆️
model_incoming_transactions.go 53.61% <100.00%> (ø)
... and 29 more

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f914f8...2547350. Read the comment docs.

action_transaction.go Outdated Show resolved Hide resolved
chainstate/broadcast_providers.go Show resolved Hide resolved
}

tx.setChainInfo(txInfo)
if err = tx.Save(ctx); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update SyncTransaction model otherwise, we will try to check the state of updated transaction during next scheduled trigger.

Actually I would suggest to make this function a common code used in callbacks and in scheduled synchronisation (so actually move there and unify code that is in a sync transaction after querying chain).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good point. I tried to handle that.

@wregulski wregulski closed this Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants