Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-368): Arc callbacks #563

Merged
merged 10 commits into from
Feb 1, 2024
Merged

feat(BUX-368): Arc callbacks #563

merged 10 commits into from
Feb 1, 2024

Conversation

wregulski
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski requested a review from a team as a code owner February 1, 2024 13:42
@wregulski wregulski self-assigned this Feb 1, 2024
@wregulski wregulski changed the base branch from master to rc-v1.1 February 1, 2024 13:43
@mergify mergify bot added the feature Any new significant addition label Feb 1, 2024
@mergify mergify bot mentioned this pull request Feb 1, 2024
7 tasks
@wregulski wregulski force-pushed the feat/368-callbacks-v2 branch from 9d1046d to 5ac2858 Compare February 1, 2024 14:19
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Comparison is base (fbc92f3) 56.82% compared to head (5ac2858) 58.94%.
Report is 64 commits behind head on rc-v1.1.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           rc-v1.1     #563      +/-   ##
===========================================
+ Coverage    56.82%   58.94%   +2.11%     
===========================================
  Files          102      103       +1     
  Lines         9876     9526     -350     
===========================================
+ Hits          5612     5615       +3     
+ Misses        3826     3472     -354     
- Partials       438      439       +1     
Flag Coverage Δ
unittests 58.94% <46.98%> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentication.go 80.52% <100.00%> (+0.02%) ⬆️
beef_bump.go 78.33% <100.00%> (ø)
beef_tx_sorting.go 100.00% <100.00%> (ø)
chainstate/broadcast_providers.go 63.93% <100.00%> (+3.22%) ⬆️
chainstate/chainstate.go 76.59% <ø> (ø)
chainstate/client.go 70.45% <ø> (ø)
chainstate/merkle_root.go 83.33% <100.00%> (+83.33%) ⬆️
chainstate/minercraft_init.go 82.35% <100.00%> (+18.48%) ⬆️
chainstate/mock_minercraft.go 27.95% <100.00%> (+11.54%) ⬆️
client.go 65.19% <ø> (ø)
... and 38 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfae9b7...5ac2858. Read the comment docs.

@wregulski wregulski merged commit 3ef205e into rc-v1.1 Feb 1, 2024
5 checks passed
@wregulski wregulski deleted the feat/368-callbacks-v2 branch February 1, 2024 14:25
Copy link
Contributor

mergify bot commented Feb 2, 2024

⚠️ The sha of the head commit of this PR conflicts with #566. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants