Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(BUX-598): broadcast in EF if possible #584

Closed
wants to merge 6 commits into from

Conversation

arkadiuszos4chain
Copy link
Contributor

@arkadiuszos4chain arkadiuszos4chain commented Feb 15, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@arkadiuszos4chain arkadiuszos4chain self-assigned this Feb 15, 2024
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@mergify mergify bot added the feature Any new significant addition label Feb 15, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (375adbd) 59.98% compared to head (8c80170) 57.74%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   59.98%   57.74%   -2.25%     
==========================================
  Files         101      102       +1     
  Lines        7323     7403      +80     
==========================================
- Hits         4393     4275     -118     
- Misses       2493     2705     +212     
+ Partials      437      423      -14     
Flag Coverage Ξ”
unittests 57.74% <40.11%> (-2.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
chainstate/transaction.go 81.31% <100.00%> (ΓΈ)
model_transactions.go 65.67% <100.00%> (-3.08%) ⬇️
action_transaction.go 29.55% <80.00%> (-4.45%) ⬇️
chainstate/broadcast.go 61.66% <71.42%> (-2.13%) ⬇️
record_tx_strategy_internal_incoming_tx.go 0.00% <0.00%> (-23.64%) ⬇️
record_tx_strategy_outgoing_tx.go 50.84% <80.00%> (-2.88%) ⬇️
record_tx.go 55.55% <41.66%> (-26.12%) ⬇️
record_tx_strategy_external_incoming_tx.go 0.00% <0.00%> (-58.11%) ⬇️
chainstate/chainstate.go 53.19% <33.33%> (-10.92%) ⬇️
chainstate/broadcast_providers.go 61.42% <66.66%> (-4.58%) ⬇️
... and 3 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dde5783...8c80170. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain marked this pull request as ready for review February 19, 2024 09:10
@arkadiuszos4chain arkadiuszos4chain requested a review from a team as a code owner February 19, 2024 09:10
ef_tx.go Show resolved Hide resolved
paymail_service_provider.go Show resolved Hide resolved
paymail_service_provider.go Show resolved Hide resolved
record_tx_strategy_external_incoming_tx.go Outdated Show resolved Hide resolved
record_tx_strategy_outgoing_tx.go Outdated Show resolved Hide resolved
ef_tx.go Show resolved Hide resolved
ef_tx.go Outdated Show resolved Hide resolved
chainstate/chainstate.go Outdated Show resolved Hide resolved
chainstate/chainstate.go Show resolved Hide resolved
chainstate/chainstate.go Show resolved Hide resolved
chainstate/chainstate.go Show resolved Hide resolved
chainstate/broadcast_providers.go Outdated Show resolved Hide resolved
chainstate/chainstate.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for inconvenience.
Those changes need to be moved into spv-wallet after renaming.

@mergify mergify bot closed this Mar 13, 2024
Copy link
Contributor

mergify bot commented Mar 13, 2024

This pull request looks stale. Feel free to reopen it if you think it's a mistake.

@mergify mergify bot added the stale Old, unused, stale label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition stale Old, unused, stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants