Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

chore(BUX-223): remove unused authentication methods #585

Closed
wants to merge 1 commit into from

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Move authentication to spv-wallet

@pawellewandowski98 pawellewandowski98 self-assigned this Feb 16, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner February 16, 2024 08:44
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@mergify mergify bot added the feature Any new significant addition label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (375adbd) 59.98% compared to head (4296ba1) 59.42%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   59.98%   59.42%   -0.57%     
==========================================
  Files         101      100       -1     
  Lines        7323     7137     -186     
==========================================
- Hits         4393     4241     -152     
+ Misses       2493     2480      -13     
+ Partials      437      416      -21     
Flag Coverage Ξ”
unittests 59.42% <0.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
authentication.go 0.00% <0.00%> (-80.75%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dde5783...4296ba1. Read the comment docs.

Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for inconvenience.
Those changes need to be moved into spv-wallet after renaming.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants