Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3-width height #100

Merged
merged 3 commits into from
Sep 16, 2024
Merged

v3-width height #100

merged 3 commits into from
Sep 16, 2024

Conversation

quirijnslings
Copy link
Contributor

Please merge v3-platform first

Bugfixes:

  • It was not possible previously to retrieve an asset containing a PowerPoint. The reason is that Bynder always adds a media item of type PDF to any PowerPoint asset. This PDF is returned by the API with a width and height of null, which broke the deserialization. In this fix, we tell Newtonsoft to simply skip properties with a value of null.

You can test with MediaSample, by simply requesting an asset with a PowerPoint in it. This will break in previous versions.

@ahongbynder ahongbynder merged commit f6791ce into Bynder:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahongbynder ahongbynder ahongbynder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quirijnslings @ahongbynder