Added uri property to UsageQuery #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@polanus Thanks for opening a pull request. Can you add some unit tests as well for the new methods being introduced, thanks. |
|
Hi @ahongbynder, thanks for your quick response! I've added a unit test for the newly added method. |
ahongbynder
approved these changes
Feb 12, 2024
|
@polanus Pull request merged and new release was created. Noticed an issue with github action that publishes new release, so pending this for latest changes to be reflected within maven repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I added the uri property to the UsageQuery class, as described in the documentation:
https://bynder.docs.apiary.io/#reference/asset-usage/asset-usage-operations/retrieve-asset-usage
This enables clients to also be able to query asset usages on the uri, instead of only on the asset id.
It would be great if this can be merged, thanks in advance!
Regards, Philippe