fix ReactMentions props and fix tests that stop local linting #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknit
approved these changes
Sep 19, 2023
@webknit it is used 😅 https://github.com/Bynder/gathercontent-gather-ui/pull/1298/files#diff-14214aaac303045d2a034883a558bd72326ec00e0698886dfe25e3eb7cd6e4f0R22 same for all the files i've imported it in. used to be globally available when we had jest, but no longer with vitest. thats why its suddenly an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Description
Newer ReactMentions have changed what props you need to pass to what component, this fixes that.
I also had errors in these tests when linking locally, so i've just fixed the imports for those too