-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new Bynder logo #1308
Merged
Merged
Adding new Bynder logo #1308
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
04db5b0
Adding new logo, new width, and border radius
webknit 202fda7
adding bynder class
webknit 841a5c0
bynder-logo class
webknit ea4de9d
adding original logo back in
webknit 26d5793
rename LogoGC
webknit cfbf20e
correct export name
webknit 2e0da54
exporting component
webknit 8f9bb93
adding original svg in
webknit bcfb954
adding gc logo story
webknit 0212a0c
correct logo path
webknit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Logo | ||
A logo component which defaults to the GatherContent logo | ||
|
||
### Props | ||
|
||
| Name | Type | Default | Required | Description | | ||
| ------------------- |-------------- | --------------------------- | -------- |------------------------------- | | ||
| url | String | '' | No | Image URL for the logo | | ||
| alt | String | 'GatherContent Logo' | No | Alt attribute for the logo | | ||
###Usage | ||
``` | ||
<Logo url="http://example.com/myimage.png" alt="Alt Tag" /> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import React from "react"; | ||
import logoGCSVG from "../../assets/logogc.svg"; | ||
|
||
/** | ||
* @usage | ||
* | ||
* <Logo url="http://example.com/myimage.png" alt="Alt Tag" /> | ||
*/ | ||
|
||
export function LogoGC(props: any) { | ||
const LogoPath = props.url || logoGCSVG; | ||
const image = | ||
typeof LogoPath === "string" ? ( | ||
<img src={props.url} alt={props.alt} className="logo__image" /> | ||
) : ( | ||
<span className="logo__image"> | ||
<LogoPath /> | ||
</span> | ||
); | ||
return <span className="logo">{image}</span>; | ||
} | ||
|
||
LogoGC.defaultProps = { | ||
url: "", | ||
alt: "GatherContent Logo", | ||
}; | ||
|
||
export default LogoGC; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* ========================================================================== | ||
Config | ||
========================================================================== */ | ||
$logo-max-height: 40px !default; | ||
$logo-max-width: 150px !default; | ||
|
||
/* ========================================================================== | ||
Styles | ||
========================================================================== */ | ||
.logo__image { | ||
max-width: $logo-max-width; | ||
max-height: $logo-max-height; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import React from "react"; | ||
import LogoGCComponent from "../../lib/LogoGC"; | ||
import StoryItem from "../styleguide/StoryItem"; | ||
|
||
export default { | ||
title: "Legacy/LogoGC", | ||
component: LogoGCComponent, | ||
}; | ||
|
||
export const LogoGC = () => ( | ||
<div> | ||
<StoryItem title="Default Logo" description="A wrapper around the logo"> | ||
<div> | ||
<LogoGCComponent /> | ||
</div> | ||
</StoryItem> | ||
|
||
<StoryItem title="Custom Logo" description=""> | ||
<LogoGCComponent | ||
url="https://dummyimage.com/150x40/3d8beb/fff.png" | ||
alt="Alt Tag" | ||
/> | ||
</StoryItem> | ||
</div> | ||
); | ||
|
||
LogoGC.parameters = { | ||
controls: { hideNoControlsWarning: true }, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This points to the same svg as the new bynder one, we need the old svg in place :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added old SVG back and also added a new story so it's clear what's what.