Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write tests after the fact, add travis config #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

andreas-bytenl
Copy link

No description provided.

@andreas-bytenl
Copy link
Author

Having a hard time nailing down dependencies that work with Python 2.6 :(

Copy link
Contributor

@kerrermanisNL kerrermanisNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, just a few questions.

@@ -35,3 +35,5 @@ nosetests.xml
.project
.pydevproject
.idea
.pytest_cache
/htmlcov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from? We don't have any HTML in here that needs to be covered, right? :P

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run pytest --cov (with some extra arguments), you'll get a directory htmlcov which shows you which parts of your code hasn't been ran by tests. I should add this to the readme.

@@ -0,0 +1,4 @@
pytest
pytest-cov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pytest specifically? All other repo's use nosetests I think. I think we should stick with the same requirements in general.

@@ -0,0 +1,4 @@
pytest
pytest-cov
prospector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's prospector?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tool that combines pylint, pyflakes and pycodestyle. Used by https://landscape.io/

@kerrermanisNL
Copy link
Contributor

Cool. What about the pytest question?

@andreas-bytenl
Copy link
Author

@kerrermanisNL I forgot about this PR. We discussed this internally, I think I tried rewriting to regular unittest but got too annoyed by it and did other things instead :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants