provider: ignore cloud: system tag key prefix as well as aws:
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nktrnv
force-pushed
the
ec2launchtemplate-tag
branch
2 times, most recently
from
1f6a5bb to
94467fc
Compare
PixarV
reviewed
Oct 24, 2024
internal/tags/key_value_tags.go
Outdated
| @@ -41,7 +42,7 @@ func (tags KeyValueTags) IgnoreAWS() KeyValueTags { | |||
| result := make(KeyValueTags) | |||
|
|
|||
| for k, v := range tags { | |||
| if !strings.HasPrefix(k, AwsTagKeyPrefix) { | |||
| if !strings.HasPrefix(k, AwsTagKeyPrefix) && !strings.HasPrefix(k, CloudTagKeyPrefix) { | |||
There was a problem hiding this comment.
Можно добавить этот кейс в тесты (key_value_tags_test.go)
PixarV
approved these changes
Oct 24, 2024
nktrnv
force-pushed
the
ec2launchtemplate-tag
branch
from
50d5d15 to
59e9c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENHANCEMENTS:
cloud:system tag key prefix as well asaws: