Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release #67

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

vamping111
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@ELatestark ELatestark self-requested a review November 26, 2024 08:57
@ELatestark
Copy link
Collaborator

image
и почисти хистори, пожалуйста

on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* - зачем?

on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

точка это "любой символ", если ты хотел мэтчить именно точку, то ее нужно экранировать

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

отмена, в гитхабе не используется стандартные регулярки, точка в гитхабе не является специальным символом

on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'v[0-9]+.[0-9]+.[0-9]+*'
- 'v[0-9]+.[0-9]+.[0-9]+'

@vamping111 vamping111 force-pushed the automate_release branch 2 times, most recently from db82138 to b5ac81b Compare December 3, 2024 21:13
@vamping111 vamping111 force-pushed the automate_release branch 5 times, most recently from 29af7d8 to 27b342d Compare December 9, 2024 10:24
@vamping111 vamping111 force-pushed the automate_release branch 2 times, most recently from 0f4df99 to 1d64ebf Compare January 16, 2025 06:36
@vamping111 vamping111 force-pushed the automate_release branch 2 times, most recently from bfa275e to 23d99d1 Compare January 16, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants