Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing icon-exclaim package #1044

Merged
merged 2 commits into from
Feb 5, 2025
Merged

removing icon-exclaim package #1044

merged 2 commits into from
Feb 5, 2025

Conversation

lxavier
Copy link
Contributor

@lxavier lxavier commented Feb 3, 2025

The package is causing an error with the icon package

The package is causing an error with the icon package
Copy link
Contributor

github-actions bot commented Feb 3, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-05 08:34 UTC

@lxavier
Copy link
Contributor Author

lxavier commented Feb 3, 2025

launch jenkins

Copy link
Contributor

@huppd huppd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean removal to me. I haven't tested if it fixes the problem.

@lxavier
Copy link
Contributor Author

lxavier commented Feb 4, 2025

launch jenkins

icon-exclaim is temporarily removed from repo
@lxavier
Copy link
Contributor Author

lxavier commented Feb 4, 2025

launch jenkins

@lxavier
Copy link
Contributor Author

lxavier commented Feb 4, 2025

in and our of source build was manually tested with branch update_spack_0.22

@lxavier
Copy link
Contributor Author

lxavier commented Feb 5, 2025

@jonasjucker the test for icon4py is failing any idea why it is affected by my change (I only touched icon-exclaim)

@lxavier
Copy link
Contributor Author

lxavier commented Feb 5, 2025

All test are ok : https://jenkins-mch.cscs.ch/job/Spack/job/spack_PR/1820/ except for the icon4py test - this one is known to be unstable - I will therefore merge

@lxavier lxavier merged commit bbc220d into main Feb 5, 2025
3 of 4 checks passed
@lxavier lxavier deleted the rm_icon-exclaim branch February 5, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants