Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2266 Support Viewing Older Data Model Versions #605

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 23, 2025

Overview

This PR extends the Model Navigator implementation to support viewing of older Data Model versions, as well as some code QoL changes.

Note

The link on the Data Submission Dashboard page is still pending UX design, but I'll implement that separately.

Change Details (Specifics)

  • Add optional version parameter to Model Navigator URL, if empty, redirect to /{model}/latest
  • Fetch the Data Model assets based on the provided version, instead of latest-version
  • Add a Model Navigator hyperlink to Data Submission list and Data Submission dashboard
  • QOL: Rename "modelNavigator" content folder to "ModelNavigator"
  • QOL: Move Upload Metadata tooltip to the DashboardTooltips config file

Related Ticket(s)

CRDCDH-2266 (Task)
CRDCDH-2159 (US)

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 23, 2025
@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 23, 2025
@amattu2 amattu2 changed the title CRDCDH-2266 Support Viewing History Model Versions in Model Navigator CRDCDH-2266 Support Viewing Older Data Model Versions Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 13057821905

Details

  • 25 of 32 (78.13%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 58.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/content/dataSubmissions/DataSubmissionsListView.tsx 0 1 0.0%
src/router.tsx 0 1 0.0%
src/hooks/useBuildReduxStore.ts 0 2 0.0%
src/content/ModelNavigator/NavigatorView.tsx 0 3 0.0%
Totals Coverage Status
Change from base Build 13057802857: 0.2%
Covered Lines: 4064
Relevant Lines: 6539

💛 - Coveralls

@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 30, 2025
@amattu2 amattu2 marked this pull request as ready for review January 30, 2025 14:49
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment with something we should address in a future PR. No changes necessary here. Great work! It is working well.

src/utils/dataModelUtils.ts Show resolved Hide resolved
@Alejandro-Vega Alejandro-Vega merged commit 845fb53 into 3.2.0 Jan 30, 2025
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2266 branch January 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants