Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2265 Support multi-select status selection #606

Open
wants to merge 2 commits into
base: 3.2.0
Choose a base branch
from

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 23, 2025

Overview

This PR allows multi-selection of the Data Submission List > Status Filter.

Note

This PR is on hold waiting for BE, and probably update the selection to match SR multi-select filter.

Change Details (Specifics)

  • Update the Status input to multi-select
  • Update the order of the status option list to match requirements
  • Update the listSubmissions API to use a Typed Document and change the input typing
  • Change searchParams implementation for the status field to an array-based implementation (status=x1&status=x2...)
  • Export the default form values and use that for the Data Submission List formRef instead of duplicating fields
  • Remove very very old MVP-1 note

Related Ticket(s)

CRDCDH-2265 (Task)
CRDCDH-2206 (US)

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 23, 2025
@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12938914830

Details

  • 14 of 16 (87.5%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 57.913%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DataSubmissions/DataSubmissionListFilters.tsx 13 14 92.86%
src/content/dataSubmissions/DataSubmissionsListView.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/DataSubmissions/DataSubmissionListFilters.tsx 3 90.94%
Totals Coverage Status
Change from base Build 12937719724: -0.04%
Covered Lines: 4026
Relevant Lines: 6518

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Do Not Merge This PR is not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants