-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextFormField separator removal #170
base: main
Are you sure you want to change the base?
Conversation
Hey @RohanSengupta326! I guess it could be better to reduce and align the underline properly. |
how about this? @ItsAdityaKSingh |
Better! Try to move that eye icon away from the underline. It should not look to be in the text field. |
That's great! Could you also just push the eye icon up a little so that it comes above the underline horizontal space? |
Is this height of the eye icon okay or is more needed? @ItsAdityaKSingh |
LGTM! @nb9960, could you review? |
so should send the PR now or wait? @ItsAdityaKSingh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why debug.keystore file is introduced?
@@ -381,12 +422,12 @@ class _AuthScreenState extends State<AuthScreen> | |||
), | |||
), | |||
), | |||
separator(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think separator widget is being used anywhere now, can you please remove the widget (wherever it is declared) too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
debug.keystore and pubspec.lock were changed automatically. |
Hey @RohanSengupta326, could you please see PR #175 and discuss the need for separate cards for the fields or have the fields on the same card? You could look at the UI and suggest your ideas there too. |
Fixes #158
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.