Fix: Updated/Replacing dependencies used. #185
Conversation
|
Hey @CyberWake, could you rebase your changes to the main branch here, as all the changes and commits are currently being added there? |
|
@ItsAdityaKSingh could you please review this PR. |
You need to rebase this PR to the |
| @@ -44,3 +44,6 @@ app.*.map.json | |||
| /android/app/debug | |||
| /android/app/profile | |||
| /android/app/release | |||
|
|
|||
| # Excluding environment file | |||
| .env | |||
There was a problem hiding this comment.
better to have *.env so that any environment file is automatically ignored
| # platform :ios, '11.0' | ||
|
|
||
| # CocoaPods analytics sends network stats synchronously affecting flutter build latency. | ||
| ENV['COCOAPODS_DISABLE_STATS'] = 'true' |
There was a problem hiding this comment.
we already have a podfile. no need for new as this one seems the same
| child: FlatButton( | ||
| splashColor: Colors.white, | ||
| highlightColor: Colors.white, | ||
| child: TextButton( |
There was a problem hiding this comment.
i assume this change is because flatbutton is deprecated. But this change doesn't match with the PR. If you're doing this upgrade, pls do it for entire project
| @@ -12,7 +12,7 @@ dependencies: | |||
|
|
|||
| cupertino_icons: ^1.0.2 | |||
| fluttertoast: ^8.0.3 | |||
| connectivity_plus: ^1.0.2 | |||
| connectivity_plus: ^3.0.3 | |||
There was a problem hiding this comment.
what's the need of this update? 1.0.2 works fine?
| import 'package:fluttertoast/fluttertoast.dart'; | ||
| import 'package:geocoder/geocoder.dart'; | ||
| import 'package:google_maps_flutter/google_maps_flutter.dart'; | ||
| import 'package:graphql_flutter/graphql_flutter.dart'; | ||
| import 'package:intl/intl.dart'; | ||
| import 'package:location/location.dart'; | ||
| import 'package:modal_progress_hud/modal_progress_hud.dart'; | ||
| import 'package:flutter_polyline_points/flutter_polyline_points.dart'; |
There was a problem hiding this comment.
are all of these unused imports?
Fixes #184
Describe the changes you have made in this PR -
The first thing that was breaking on android side was the
compileSdkVersionwhich was set to 30 previously which needed to be 30 to fix the following error Screenshot 1.in android
android/build.gradleneeded update inext.kotlin_versionto resolve the following error shown in Screenshot 2.The second fix was to update package
graphql_flutterwas needed updated to latest version. Which requiredconnectivity_plusto be updated to its latest version which in turn requiredrxdartto be updated to its latest version. This was done to resolve the error shown in Screenshot 3.flutter_duration_pickeris no longer maintained by the owner hence the newer updated fork published as a package on pub dev was used. This was done to resolve error shown in Screenshot 4.Added
.envtogitignoreto ensure the environment variables don't get pushed to GitHub.Screenshots of the changes (If any) -