Add Node Networking Configuration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajamias
force-pushed
the
networking
branch
10 times, most recently
from
ffdfc18 to
4fa533f
Compare
tzumainn
requested changes
Jul 31, 2024
There was a problem hiding this comment.
The UI looks really good! Some issues and suggestions:
- is it possible to take out the "Back / Next" buttons? They imply it's multiple steps for the wizard
- I can't seem to get the network detach to work; weirdly, in the log I see the error that the node has no free ports. I wonder if this happens when a node's ports are all occupied, and someone tries to detach a port?
- I really like the MAC address selection bar; can you change the "blank" option to "any", to make it clear to the user that it's something that can be left untouched?
After pressing the 'Actions' button, the user will be shown a config wizard to either attach a network/port/trunk (to a specified MAC address) or detach a port. After the request is submitted, the node's network info will automatically refresh when the request is successful.
|
It isn't possible to remove the back/next buttons because that is part of the wizard template. I fixed the other two bullet points though. |
tzumainn
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pressing the 'Actions' button, the user will be shown a config wizard to either attach a network/port/trunk (to a specified MAC address) or detach a port. After the request is submitted, the node's network info will automatically refresh when the request is successful.