Added port creation and floating IP logic. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a more general note - you'll likely want to deploy this locally and test with updated UI code. In my experience, these method signatures can fluctuate as the UI changes, and it's better to test them together rather than have multiple incremental updates to the SDK. |
|
Link to the esi-ui PR - CCI-MOC/esi-ui#27 |
tzumainn
requested changes
Nov 5, 2024
esi/lib/networks.py
Outdated
| :return: The created port object | ||
| """ | ||
| if not name: | ||
| name = 'esi-port-{0}'.format(network.name) |
There was a problem hiding this comment.
Can you name the port the same way we do here? https://github.com/CCI-MOC/esisdk/blob/main/esi/lib/nodes.py#L212
It actually probably makes sense to create a new port_name function, and just call it both here and in the place that I linked.
|
@tzumainn Look into this and UI code both are updated. |
tzumainn
reviewed
Nov 6, 2024
tzumainn
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: