migrate node network list functionality into esisdk

[ajamias]

The python-esiclient and esi-ui packages depend on the same functionality. This PR starts to centralize that logic so no code repetition is done. The first function to be added is openstack esi node network list.

[tzumainn]

I'll take a closer look tomorrow, but one thing sticks out: we want to return data, and not the column headers. I'd consider the headers part of the formatting, and that belongs in python-esiclient. Another way to think of this, is if you want to use this function in the UI, you're only going to want data.

[tzumainn]

Taking that one step forward, I wonder if this might be best returned as a list of dictionaries, where each dictionary is something like:

{
    "node": <node object>,
     "ports": [{
           "baremetal_port": <baremetal port object>,
           "neutron_port": <neutron port object>,
           "floating_ip": <floating ip information>
          },
          <additional ports>
       ]
}

Then the client gets to interpret the information however they'd like.

This would imply that some of the functions in utils.py that do formatting - like get_network_display_name - would still belong in python-esileapclient

[tzumainn]

Good start! I've left comments inline.

[tzumainn]

Looks pretty good! A few last things:

• there's a lint error; make sure you run tox -epep8
• can you squash the commits? make sure the new one commit has a good comprehensive title/description
• can you update your python-esiclient PR so I can test against this?

[ajamias]

* can you update your python-esiclient PR so I can test against this?

The python-esiclient PR doesn't have fully updated test cases, only the source code, but I'll update it right now

[tzumainn]

Thanks for the update! After testing, I've noted three differences in output. They could all very well be due to presentation python-esiclient, but you may want to be sure:

• The external network now shows its VLAN. Honestly... this is better so I'd keep this.
• If a floating IP exposes its whole range (and not just a port forwarding), there's empty parentheses that weren't there before.
• The tagged ports in a trunk port don't show their fixed IP addresses.

| MOC-R4PAC21U25-S1 | 0c:42:a1:7b:e4:f0 | esi-esi-MOC-R4PAC21U25-S1-trunk-tzumainn-trunk-port | tzumainn (626)  | 192.168.50.140 | external (3801)  | 128.31.20.114 () |
|                   |                   |                                                     | tzumainn2 (600) |                |                  |                  |

[ajamias]

Thanks for the update! After testing, I've noted three differences in output. They could all very well be due to presentation python-esiclient, but you may want to be sure:

* The external network now shows its VLAN. Honestly... this is better so I'd keep this.

* If a floating IP exposes its whole range (and not just a port forwarding), there's empty parentheses that weren't there before.

* The tagged ports in a trunk port don't show their fixed IP addresses.

| MOC-R4PAC21U25-S1 | 0c:42:a1:7b:e4:f0 | esi-esi-MOC-R4PAC21U25-S1-trunk-tzumainn-trunk-port | tzumainn (626)  | 192.168.50.140 | external (3801)  | 128.31.20.114 () |
|                   |                   |                                                     | tzumainn2 (600) |                |                  |                  |

these should be fixed now

[tzumainn]

This looks really good! The one thing missing is in the test cases, which should have assert_called and assert_not_called (as in https://github.com/CCI-MOC/esi-leap/blob/master/esi_leap/tests/api/controllers/v1/test_utils.py#L262). The reason is that this is often a way to ensure that conditional branches are followed correctly.

Once that's included, I think this will be ready to merge!

[tzumainn]

Looks good - thanks!