Feature/ignore hours #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naved001
force-pushed
the
feature/ignore-hours
branch
2 times, most recently
from
b9a5337
to
3ce1ec2
Compare
knikolla
reviewed
Oct 23, 2024
knikolla
approved these changes
Oct 24, 2024
* Use the property to get end_time * fix the comparison of start and end dates when taking user input * Specify UTC timzone when creating datetime object
naved001
force-pushed
the
feature/ignore-hours
branch
from
3ce1ec2
to
7c395a9
Compare
|
@knikolla I added a new commit that addresses your comments and the timezone thing. |
knikolla
approved these changes
Oct 24, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature to allow us to ignore certain hours to not be billed. This works by ignoring those hours from being excluded from a pod's runtime.
Right now, the CLI can accept a bunch of timestamps to ignore but I think ultimately it'll come from the nerc-rates repo.
I
am still working on writing a testhave added tests for write_metrics_by_namespace with hours to ignore and a similar one for write_metrics_by_pod.