Accept absolute paths for filenames #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the merge.py, we now take in the names for the invoice file and the pod report file. The names of the S3 keys are calculated are not affected by this. In the metrics collection script, the now output file name is also absolute. We no longer create any directory to organize the metrics in a folder. However when the names are uploaded to the S3 bucket, the key is organized and the names are calculated. This allows us to generated the files in /tmp (or any other directory) with arbritary names but the file names uploaded to s3 are still calculated.
knikolla
reviewed
Oct 30, 2024
| os.makedirs(directory_name) | ||
|
|
||
| output_file = os.path.join(directory_name, output_file) | ||
| if report_start_date == report_end_date: |
There was a problem hiding this comment.
Err, sorry, need more coffee.
knikolla
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the merge.py, we now take in the names for the invoice file and the pod report file. The names of the S3 keys are calculated are not affected by this.
In the metrics collection script, the now output file name is also absolute. We no longer create any directory to organize the metrics in a folder. However when the names are uploaded to the S3 bucket, the key is organized and the names are calculated.
This allows us to generated the files in /tmp (or any other directory) with arbritary names but the file names uploaded to s3 are still calculated.