Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to group invoices by PIs #10

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

QuanMPhm
Copy link
Contributor

Closes #7, I have modified process_report.py to group the merged invoices into ones grouped by PIs. These smaller CSVs will be placed in a folder of your choice, or defaults to a one placed in the working directory

remove_billables(merged_dataframe, pi, projects, "non_billable.csv")
export_pi_billables(billable_projects, args.output_folder)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also make this optional and triggered by a flag? I think the default behavior should still be to produce the 2 reports i.e. billable and non-billable, but the user can say --export-by-pi and then it should split it out into multiple files. @joachimweyl thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, as long as it is a flag we know to use and use every month until we decide to be done with it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuanMPhm pointed out that the billable csv is still written, so I am okay with the current behavior then and don't care much about the flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naved001 @joachimweyl It should only take minutes for me to make it optional for the script to export the invoice csv by pi or as combined or as both. I'll do what you prefer.

@naved001 naved001 merged commit 1823ed2 into CCI-MOC:main Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add post invoice script automation script to break Invoice into groups by PI
3 participants