Allow invoice subclasses to explicitly declare their exported columns and column names #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
force-pushed
the
100/declare_exported_col
branch
from
aacb054 to
b5ca684
Compare
naved001
reviewed
Sep 25, 2024
knikolla
requested changes
Sep 26, 2024
QuanMPhm
force-pushed
the
100/declare_exported_col
branch
3 times, most recently
from
bfe8192 to
e616718
Compare
naved001
approved these changes
Oct 7, 2024
QuanMPhm
force-pushed
the
100/declare_exported_col
branch
from
e616718 to
f29a39b
Compare
… and column names Two class attributes, `export_columns_list` and `exported_columns_map`, has been added to `Invoice`, along with a class function `_filter_columns()`. Subclasses of `Invoice` must now define `export_columns_list`, containing the ordered list of columns that must be exported in their respective invoices. Subclasses can optional define `exported_columns_map`, containing mappings between "internal" column names and what their name should be when exported. The field name `RATE_FIELD` has been added to `invoice.py`. It was previously forgotten.
QuanMPhm
force-pushed
the
100/declare_exported_col
branch
from
f29a39b to
3e2a7dc
Compare
knikolla
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100. Two class attributes,
export_columns_listandexported_columns_map, has been added toInvoice, along with a class function_filter_columns(). Subclasses ofInvoicemust now defineexport_columns_list, containing the ordered list of columns that must be exported in their respective invoices. Subclasses can optional defineexported_columns_map, containing mappings between "internal" column names and what their name should be when exported.The field name
RATE_FIELDhas been added toinvoice.py. It was previously forgotten.