Removed projects duplicates when applying BU subsidy #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naved001
reviewed
May 6, 2024
QuanMPhm
force-pushed
the
25.2/remove_deplicate
branch
from
35ccf85
to
f9ea305
Compare
QuanMPhm
force-pushed
the
25.2/remove_deplicate
branch
from
f9ea305
to
a88a9b3
Compare
naved001
approved these changes
May 13, 2024
knikolla
approved these changes
May 16, 2024
|
@naved001 if you're satisfied with the responses to your comments please mark the conversations as resolved. |
|
@knikolla done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally closes #25, I've added some lines to remove duplicate projects from the BU internal invoice along with the corresponding changes to the test cases.
The cost, credit, and balance fields are now summed up before applying the subsidy.
While writing this I had to be a bit careful with knowing whether certain indexing and assignment operations were returning copies or references. I'll address this in a PR soon?