Experience/16759/code mapping results page #17436
Conversation
etanb
added
experience
etanb
requested review from
jpandersen87,
victor-chaparro and
jillian-hammer
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
|
||
| export type CodeMappingFormProps = PropsWithChildren; | ||
| interface CodeMappingFormProps { | ||
| onSubmitHandler: FormEventHandler<HTMLFormElement>; |
There was a problem hiding this comment.
nit: rename to onSubmit to follow event handler property names on dom elements
| interface CodeMappingResultsProps { | ||
| fileName: string; | ||
| data: CodeMapData[]; | ||
| initialStepHandler: () => void; |
There was a problem hiding this comment.
nit: maybe rename to onReset, if that's what is practically happening on button usage
| ) : ( | ||
| <Alert type={"error"} heading={"Your file contains unmapped codes "}> | ||
| Review unmapped codes for any user error, such as a typo. If the unmapped codes are accurate, | ||
| download the table and send the file to your onboarding engineer or [email protected]. Our |
There was a problem hiding this comment.
missing hyperlinks:
- "download the table" should be linked to download the CSV. ok if this is just a placeholder link as a reminder to implement it once the CSV functionality is incorporated.
- "[email protected]" should be hyperlinked to
mailto:[email protected]
There was a problem hiding this comment.
Talked via Slack: we have a discrete ticket for downloading the CSV and will tackle this then.
|
Branch deployed to Chromatic 🚀.
View via: |
|
|
This PR adds the Code Map Result F/E code which includes:
This PR explicitly does not include:
Sample:
Fixes #16759