-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shanice/upgrade terraform #8102
Conversation
… data.log_analytics_workspace_id covers this configuration
Quality Gate passedIssues Measures |
Since we're still using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
Tested the following flows on dev2
Sign up
- sign up for new org
Support admin - updated device
- edit pending org
- verify pending org
- add org admin
- delete facility
- delete/undelete user
- unarchive patient
Other flows
- dashboard
- submit result
- bulk upload result
- download result
- archive patient
- edit patient
- pxp results view
@shanice-skylight Let me know if there's anything else I can check or test out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my concerns have been addressed! Thank you for your hard work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, Shanice!
* initial commit for tf upgrade to 4.0.1 * initial commit for tf upgrade to 4.0.1 * modifying required_version to previous version * changed the provider version back to original and only changed terraform version * modified terraform actions in remaining github workflows * modified the setup-terraform version for all github actions * modified okta-global version * modified all config.tf versions to 1.9.5 except for global * fixed find and replace glitch * modified global * removed the attribute retention_policy due to it being deprecated and data.log_analytics_workspace_id covers this configuration * removed attribute from azurerm_log_analytics_workspace * ran script upgradetf.sh to upgrade the lock file for all environments * upgraded TF to 1.9.6 and setup-terraform to 3.1.2 * re added the retention_policy
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
Additional Information
Testing
Deployed the changes to the following environments [
dev1
,dev4
,dev2
,dev3
] and completed smoke testingThe following workflows have been tested on the environments mentioned above: