Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shanice/upgrade terraform #8102

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Shanice/upgrade terraform #8102

merged 15 commits into from
Oct 10, 2024

Conversation

shanice-skylight
Copy link
Collaborator

@shanice-skylight shanice-skylight commented Sep 3, 2024

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Update Terraform to the latest.

Additional Information

  • I tested these upgrades locally and didn't run into any issues with the upgrade or state migration.
  • I plan to merge this off hour

Testing

  • Deployed the changes to the following environments [dev1, dev4, dev2, dev3 ] and completed smoke testing

  • The following workflows have been tested on the environments mentioned above:

      - creating a new org
      - creating a new facility
      - adding a patient
      - bulk uploading patients
      - submitting a single entry test
      - submitting a bulk csv result upload
      - self registering a patient
    

@shanice-skylight shanice-skylight marked this pull request as ready for review September 19, 2024 17:40
@shanice-skylight shanice-skylight self-assigned this Sep 19, 2024
Copy link

sonarcloud bot commented Sep 23, 2024

@shanice-skylight
Copy link
Collaborator Author

Since we're still using hashicorp/azurerm 3.100.0 , I Re-added retention_policy and will replace it with azurerm_storage_management_policy during the hashicorp/azurerm 3.100.0 upgrade. I deployed the change to dev1, dev2, dev3, and dev4. OMHS placed tags is a separate from this PR and applied by OMHS not this PR's code.

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

Tested the following flows on dev2
Sign up

  • sign up for new org
    
Support admin
  • updated device
  • edit pending org
  • verify pending org
  • add org admin
  • delete facility
  • delete/undelete user
  • unarchive patient

Other flows

  • dashboard
  • submit result
  • bulk upload result
  • download result
  • archive patient
  • edit patient
  • pxp results view

@shanice-skylight Let me know if there's anything else I can check or test out!

Copy link
Collaborator

@rin-skylight rin-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my concerns have been addressed! Thank you for your hard work on this!

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this, Shanice!

@shanice-skylight shanice-skylight added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@shanice-skylight shanice-skylight added this pull request to the merge queue Oct 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
* initial commit for tf upgrade to 4.0.1

* initial commit for tf upgrade to 4.0.1

* modifying required_version to previous version

* changed the provider version back to original and only changed terraform version

* modified terraform actions in remaining github workflows

* modified the setup-terraform version for all github actions

* modified okta-global version

* modified all config.tf versions to 1.9.5 except for global

* fixed find and replace glitch

* modified global

* removed the attribute retention_policy due to it being deprecated and data.log_analytics_workspace_id covers this configuration

* removed attribute from azurerm_log_analytics_workspace

* ran script upgradetf.sh to upgrade the lock file for all environments

* upgraded TF to 1.9.6 and setup-terraform to 3.1.2

* re added the retention_policy
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@shanice-skylight shanice-skylight added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 0fc7b5b Oct 10, 2024
58 checks passed
@shanice-skylight shanice-skylight deleted the shanice/upgrade-terraform branch October 10, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants