Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set node version to 23.1 (#8280)" #8301

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Revert "Set node version to 23.1 (#8280)" #8301

merged 1 commit into from
Nov 25, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Nov 20, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue & Changes Proposed

Additional Information

Testing

  • Deployed to dev3

Screenshots / Demos

  • N/A

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emyl3 emyl3 marked this pull request as ready for review November 22, 2024 22:31
mehansen
mehansen approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

mpbrown
mpbrown approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@emyl3 emyl3 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit a9bdb2f Nov 25, 2024
50 of 51 checks passed
@emyl3 emyl3 deleted the elisa/revert-node-version branch November 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen mehansen approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

@bobbywells52 bobbywells52 Awaiting requested review from bobbywells52

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyl3 @mehansen @mpbrown