Rename reportId variables

[pluckyswan]

Description

Rename variables, like (sent/received)SubmissionId and (sent/received)MessageId to be (inbound/outbound)ReportId, and any related functions. The naming, inbound and outbound, is from the perspective of TI. The id that we were receiving from ReportStream is now the inbound id while the id we were sending to ReportStream is now the outbound id.

Issue

#1404

Checklist

• I have added tests to cover my changes
• I have added logging where useful (with appropriate log level)
• I have added JavaDocs where required
• I have updated the documentation accordingly

Note: You may remove items that are not applicable

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Consistency Check Ensure that the renaming of variables from 'receivedSubmissionId' to 'inboundReportId' maintains consistency across all related methods and classes, especially where method signatures and return types might be affected.

[github-actions]

PR Code Suggestions ✨

No code suggestions found for the PR.

[basiliskus]

I reviewed a few of the changes and added a couple of comments. I'll continue reviewing later

[basiliskus]

Left one comment. Otherwise looking great!

[pluckyswan]

Left one comment. Otherwise looking great!

Did we want to change recordId to reportId? Or is that a different card?

[basiliskus]

Did we want to change recordId to reportId? Or is that a different card?

That would be a different card. It involves changes in RS, so we need to coordinate to make those changes in TI and RS at the same time

[halprin]

Wow, this is great work. If you're going keep the modifications in DatabasePartnerMetadataStorage.java, then you'll need to also add a database migration in this PR, so that everything works when this PR is merged.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud