Fixed failing of lysp_check_date when using DST configurations with savingtimes >=24h #2310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled DST by setting tm_isdst to -1 so that mktime() won't adjust for daylight saving time.
This is especially important for custom DST settings.
Without this fix
lysp_check_date()
fails due toif (tm.tm_mday != tm_.tm_mday)
This bug can be reproduced i.e. by creating a custom DST like this one:
custom_timezone.txt
zic custom_timezone.txt
cp /usr/share/zoneinfo/Custom/TZ /etc/localtime
export TZ="Custom/TZ"
date
anddate -u
have different days due to the insane DST configuration.Also this fix is compatible with the previous issue when using TZ "Europe/Dublin".