Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyhedron Demo: Add sampling plugin #7910

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

afabri
Copy link
Member

@afabri afabri commented Dec 5, 2023

Summary of Changes

Add a plugin that samples meshes and polygon soups

Todo

  • Add dialog for the various parameters of the sampling function
  • Check that the input is triangular.

Release Management

  • Affected package(s): Polyhedron
  • License and copyright ownership: unchanged

@afabri afabri requested a review from sloriot December 5, 2023 14:22
@afabri afabri added this to the 6.0-beta milestone Dec 5, 2023
…nt_set_from_sampling_plugin.cpp

Co-authored-by: Laurent Rineau <[email protected]>
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_1 First Batch of PRs under testing labels Dec 6, 2023
@sloriot
Copy link
Member

sloriot commented Dec 11, 2023

Successfully tested in CGAL-6.0-Ic-124 (but there are still todos)

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Dec 11, 2023
@lrineau lrineau self-assigned this Dec 11, 2023
@lrineau lrineau added TODO and removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Dec 11, 2023
@lrineau
Copy link
Member

lrineau commented Dec 11, 2023

@afabri Will you finish the pull-request, or do you plan to delegate the remaining TODOs to one of us?

Or let me know if you want this PR merged as it is.

@github-actions github-actions bot removed the Tested label Dec 12, 2023
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@afabri
Copy link
Member Author

afabri commented Dec 12, 2023

@afabri Will you finish the pull-request, or do you plan to delegate the remaining TODOs to one of us?

Or let me know if you want this PR merged as it is.

The todos are done now,

@sloriot sloriot removed the TODO label Dec 14, 2023
@sloriot
Copy link
Member

sloriot commented Dec 14, 2023

  • 196>C:\CGAL_ROOT\CGAL-6.0-Ic-127\test\Polyhedron_Demo\Plugins\Operations_on_polyhedra\Point_set_from_sampling_plugin.cpp(117,42): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\CGAL_ROOT\CGAL-6.0-Ic-127\cmake\platforms\MSVC-2019-Community-Release\test\Polyhedron_Demo\Plugins\Operations_on_polyhedra\point_set_from_sampling_plugin.vcxproj]

  • C:\CGAL_ROOT\CGAL-6.0-Ic-127\test\Polyhedron_Demo\Plugins\Operations_on_polyhedra\Point_set_from_sampling_plugin.cpp(117,42): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\CGAL_ROOT\CGAL-6.0-Ic-127\cmake\platforms\MSVC-2019-Community-Release\test\Polyhedron_Demo\Plugins\Operations_on_polyhedra\point_set_from_sampling_plugin.vcxproj]

  • C:\CGAL_ROOT\CGAL-6.0-Ic-127\include\CGAL/Polygon_mesh_processing/distance.h(265,38): warning C4244: 'initializing': conversion from 'const T' to 'size_t', possible loss of data [C:\CGAL_ROOT\CGAL-6.0-Ic-127\cmake\platforms\MSVC-2019-Community-Release\test\Polygon_mesh_processing_Examples\sample_example.vcxproj]

@sloriot
Copy link
Member

sloriot commented Dec 18, 2023

Successfully tested in CGAL-6.0-Ic-129

@sloriot sloriot assigned sloriot and unassigned lrineau Dec 18, 2023
@sloriot sloriot merged commit b9696c2 into CGAL:master Dec 18, 2023
9 checks passed
@sloriot sloriot deleted the Polyhedron_sample_plugin-GF branch December 18, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants