Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh_3 with edge_min_size - make uses of curve_segment_length() consistent #8029

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Mesh_3 with edge_min_size - make uses of curve_segment_length() consistent #8029

merged 2 commits into from
Feb 16, 2024

Conversation

janetournois
Copy link
Member

Summary of Changes

This PR completes PR #7863
The use of curve_segment_length() may be invalid when edge_min_size criterion is used, and hence the graph of features may be invalid.
With this PR, we make sure that the invalid-feature-graph-protected version of curve_segment_length() is used everywhere consistently.

Release Management

  • Affected package(s): Mesh_3
  • License and copyright ownership: unchanged

@janetournois janetournois added this to the 5.6.1 milestone Feb 12, 2024
@sloriot
Copy link
Member

sloriot commented Feb 14, 2024 

CGAL/Mesh_3/Protect_edges_sizing_field.h:1090:64: warning: variable 'cp' set but not used [-Wunused-but-set-variable]
CGAL/Mesh_3/Protect_edges_sizing_field.h:2109:64: warning: unused variable 'cp' [-Wunused-variable]
CGAL/Mesh_3/Protect_edges_sizing_field.h:2115:25: warning: unused variable 'wp1' [-Wunused-variable]
CGAL/Mesh_3/Protect_edges_sizing_field.h:2116:25: warning: unused variable ‘wp2’ [-Wunused-variable]
CGAL/Mesh_3/Protect_edges_sizing_field.h:2117:25: warning: unused variable ‘wp3’ [-Wunused-variable]

@sloriot sloriot added Batch_1 First Batch of PRs under testing Tested and removed Tests failing (warning) Under Testing Batch_1 First Batch of PRs under testing labels Feb 14, 2024
@sloriot
Copy link
Member

sloriot commented Feb 16, 2024

Successfully tested in CGA-6.0-Ic-173

@lrineau lrineau self-assigned this Feb 16, 2024
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Feb 16, 2024
@lrineau lrineau merged commit f407ea4 into CGAL:5.6.x-branch Feb 16, 2024
8 checks passed
lrineau added a commit that referenced this pull request Feb 16, 2024
@lrineau
Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtour…
a32899f 
…nois

Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Feb 16, 2024
@lrineau lrineau deleted the Mesh_3-edge_min_size-jtournois branch February 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
Bug Merged_in_5.6.1 Merged_in_5.6.2 Merged_in_6.0 Pkg::Mesh_3 Tested
Projects
None yet
Milestone
5.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@janetournois @sloriot @lrineau