Nef_3: Fix issue with the size of the inf box #8646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sloriot
reviewed
Dec 6, 2024
sloriot
force-pushed
the
Nef_3-Issue8644-GF
branch
from
43a55af to
eace8cc
Compare
|
So it fails on some platforms in testsuite 6.1-Ic-38 |
This comment was marked as outdated.
This comment was marked as outdated.
Closed
afabri
commented
Jan 31, 2025
sloriot
changed the title
without the abs the intersection line of x=-1 and z=-1 would be on the box leading to invalid behavior (and degenerate halfedges)
sloriot
force-pushed
the
Nef_3-Issue8644-GF
branch
from
a335732 to
ca17f81
Compare
|
Successfully tested in CGAL-6.1-Ic-78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes Issue #8644
Release Management