Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document point() in all triangulations #8658

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Document point() in all triangulations #8658

wants to merge 8 commits into from

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Dec 13, 2024 •
edited
Loading

Summary of Changes

point(Vertex_handle) and point(Simplex, int) was only documented in few triangulations (T3, ToS2), but exist in (almost, P4HT2 is the exception) all triangulations.

This PR documents it where the functions exist, as they are useful to create packages that are triangulation-agnostic, such as alpha shapes.

Release Management

  • Affected package(s): Triangulations
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): Generalize point function in triangulations -- Pre-approved 2025-02-06
  • Link to compiled documentation (obligatory for small feature) compiled doc
  • License and copyright ownership: no change (various)

@MaelRL MaelRL added this to the 6.1-beta milestone Dec 13, 2024
@sloriot
Copy link
Member

sloriot commented Dec 23, 2024

Successfully tested in CGAL-6.1-Ic-45

@MaelRL MaelRL added pre-approved For pre-approved small features. After 15 days the feature will be accepted. and removed Not yet approved The feature or pull-request has not yet been approved. CHANGES.md not updated labels Feb 6, 2025
@github-actions github-actions bot removed the Tested label Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@MaelRL MaelRL force-pushed the Tr-Document_point-GF branch from 745be67 to 94bd217 Compare February 6, 2025 19:16
lrineau
lrineau reviewed Feb 10, 2025
View reviewed changes
Installation/CHANGES.md Outdated Show resolved Hide resolved
@MaelRL @lrineau
Fix typo
b2ea32c 
Co-authored-by: Laurent Rineau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau left review comments

Assignees
No one assigned
Labels
Pkg::Hyperbolic_triangulation_2 Pkg::Periodic_2_Triangulation_2 Pkg::Periodic_3_Triangulation_3 Pkg::Triangulation_2 pre-approved For pre-approved small features. After 15 days the feature will be accepted. Ready to be tested Small feature
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@MaelRL @sloriot @lrineau