Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always init time_stamp to -2 #8714

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Always init time_stamp to -2 #8714

wants to merge 7 commits into from

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Jan 24, 2025

It is not clear to me that this is the right thing to do:

  • it is done for some classes
  • but in some test, a comment mention that it should be uninitialized (the test works if init to -1 but not to 0).
  • Base_time_stamper is doing an init to -2

@sloriot
Copy link
Member Author

sloriot commented Jan 27, 2025

After internal discussion, the rational for not initializing the time_stamp was to be able to reused time_stamp from removed elements.

@lrineau lrineau changed the title Always init time_stamp to -1 Always init time_stamp to -2 Jan 31, 2025
@lrineau lrineau added this to the 6.1-beta milestone Jan 31, 2025
@lrineau
bug fix
d582ec6
@lrineau
Bug with Linear_cell_complex
45da368 
One cannot call `std::allocator_traits<Alloc>::construct`, because some of linear cell complex classes have protected constructors with a lot of friend classes. They cannot be friend of all possible allocator classes, so...
@lrineau lrineau force-pushed the CGAL-time_stamp_init branch from b030c4e to 45da368 Compare January 31, 2025 18:20
@sloriot
Copy link
Member Author

sloriot commented Feb 1, 2025

  • Runtime error here (and also on other plateforms)

@lrineau
fix an unrelated warning
094507c 
That is not correct C++ code to copy uninitialized values.
@sloriot
Copy link
Member Author

sloriot commented Feb 5, 2025

Still errors in STL_extension test in CGAL-6.1-Ic-79

@lrineau
Copy link
Member

lrineau commented Feb 10, 2025

Still errors in STL_extension test in CGAL-6.1-Ic-79

That's right. There was an issue with Compact_container::reserve and timestamps. Fixed in lastest commit fa83d0b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau approved these changes

Assignees

@sloriot sloriot

Labels
Pkg::Mesh_3 Pkg::SMDS_3 Pkg::STL_Extension Ready to be tested Under Testing
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@sloriot @lrineau