Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(INF-2668) Add report for CHTC jobs on the OSPool #72

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

williamnswanson
Copy link
Collaborator

Subset-ed to just those that ran on the OSPool.
For Jira Issue INF-2668.

subset-ed to just those that ran on the OSPool.
@williamnswanson williamnswanson added the enhancement New feature or request label Jan 24, 2025
@williamnswanson williamnswanson self-assigned this Jan 24, 2025
Copy link
Collaborator

@jasoncpatton jasoncpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented a couple things just to keep in mind, but otherwise LGTM, merging. Thank you!

remote_pool = set()
if "LastRemotePool" in ad and ad["LastRemotePool"]:
remote_pool.add(ad["LastRemotePool"])
else:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This else block isn't technically necessary here since currently none of the chtc.wisc.edu APs will have the OSPool central manager as their CollectorHost, but it's probably good to leave it in for future-proofing in case that ever changes.

start = datetime.fromtimestamp(start_ts)
if report_period in ["daily", "weekly", "monthly"]:
start_date = start.strftime("%Y-%m-%d")
subject_str = f"CHTC AP on OSPool {report_period.capitalize()} Usage Report {start_date}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask for some feedback from the RCFs on the email subject, but this is good for now.

@jasoncpatton jasoncpatton merged commit 9b3d0e2 into master Jan 29, 2025
@jasoncpatton jasoncpatton deleted the INF-2668.chtc-on-ospool-reports branch January 29, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants