Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retrospective url generaton function to include zarr s3 #37

Open
sepehrkrz opened this issue Nov 14, 2023 · 3 comments
Open

Update retrospective url generaton function to include zarr s3 #37

sepehrkrz opened this issue Nov 14, 2023 · 3 comments
Assignees

Comments

@sepehrkrz
Copy link

sepehrkrz commented Nov 14, 2023

Current base url list for retrospective files does not include the CIROH-developed zarr archive for NWM 2.1 retrospective output. Those files are here:
https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/index.html#noaa-nwm-retrospective-2-1-zarr-pds/

See here:

nwmurl/nwmurl/urlgennwm.py

Lines 164 to 169 in d2b9676

urlbasedict_retro = {
1: "https://noaa-nwm-retrospective-2-1-pds.s3.amazonaws.com/",
2: "s3://noaa-nwm-retrospective-2-1-pds/",
3: "https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/",
4: "https://noaa-nwm-retrospective-3-0-pds.s3.amazonaws.com/CONUS/netcdf/",
}

manjirigunaji pushed a commit to manjirigunaji/nwmurl that referenced this issue Jan 22, 2024
@jameshalgren
Copy link
Member

@sepehrkrz Is this already complete? Is the only task here to insert a demonstrative test case?

@jameshalgren
Copy link
Member

@sepehrkrz Is this already complete? Is the only task here to insert a demonstrative test case?

Answering my own question: No.

The need here is for s3://... and the only protocol for this endpoint we have set up is https://...

@jameshalgren
Copy link
Member

@karnesh
Do we need both s3 and https entries in the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants